morningman commented on code in PR #31736:
URL: https://github.com/apache/doris/pull/31736#discussion_r1512227937
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/ListPartitionItem.java:
##########
@@ -180,15 +180,4 @@ public String toSql() {
return sb.toString();
}
-
- // If any partition key is hive default partition, return true.
- // Only used for hive table.
- public boolean isHiveDefaultPartition() {
- for (PartitionKey partitionKey : partitionKeys) {
Review Comment:
No, `isDefaultPartition()` is for other cases.
"default" partition is not "null" partition.
the `_HIVE_DEFAULT_PARTITION_` is actually "null" partition in Doris
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
