xy720 commented on a change in pull request #6895:
URL: https://github.com/apache/incubator-doris/pull/6895#discussion_r733486732
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/metric/DorisMetricRegistry.java
##########
@@ -34,7 +36,12 @@ public DorisMetricRegistry() {
}
public synchronized void addPaloMetrics(Metric paloMetric) {
- paloMetrics.add(paloMetric);
+ // No metric needs to be added to the Checkpoint thread.
+ // And if you add a metric in Checkpoint thread, it will cause the
metric to be added repeatedly,
+ // and the Checkpoint Catalog may be saved incorrectly, resulting in
FE memory leaks.
Review comment:
Why does adding a metric repeatedly lead to incorrectly problem in
saving the checkpoint catalog, causing the catalog intances to be greater than
2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
