github-actions[bot] commented on code in PR #31816:
URL: https://github.com/apache/doris/pull/31816#discussion_r1512705310
##########
be/src/util/url_coding.cpp:
##########
@@ -21,6 +21,7 @@
#include <memory>
#include <sstream>
+#include <turbob64.h>
Review Comment:
warning: 'turbob64.h' file not found [clang-diagnostic-error]
```cpp
#include <turbob64.h>
^
```
##########
be/src/util/url_coding.cpp:
##########
@@ -91,7 +92,7 @@
size_t len = in.size();
// Every 3 source bytes will be encoded into 4 bytes.
std::unique_ptr<unsigned char[]> buf(new unsigned char[(((len + 2) / 3) *
4)]);
- const auto* s = reinterpret_cast<const unsigned char*>(in.data());
+ const unsigned char* s = reinterpret_cast<const unsigned char*>(in.data());
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
const auto* s = reinterpret_cast<const unsigned char*>(in.data());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
