morningman commented on code in PR #31585:
URL: https://github.com/apache/doris/pull/31585#discussion_r1510555184
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateTableInfo.java:
##########
@@ -867,9 +717,13 @@ public CreateTableStmt translateToLegacyStmt() {
throw new AnalysisException(e.getMessage(), e.getCause());
}
} else if (!engineName.equals("olap")) {
- if (partitionDesc != null || distributionDesc != null) {
+ if (!engineName.equals("hms") && distributionDesc != null) {
Review Comment:
```suggestion
if (!engineName.equals("hive") && distributionDesc != null) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateTableInfo.java:
##########
@@ -867,9 +717,13 @@ public CreateTableStmt translateToLegacyStmt() {
throw new AnalysisException(e.getMessage(), e.getCause());
}
} else if (!engineName.equals("olap")) {
- if (partitionDesc != null || distributionDesc != null) {
+ if (!engineName.equals("hms") && distributionDesc != null) {
throw new AnalysisException("Create " + engineName
- + " table should not contain partition or distribution
desc");
+ + " table should not contain distribution desc");
+ }
+ if (!engineName.equals("hms") && !engineName.equals("iceberg") &&
partitionDesc != null) {
Review Comment:
```suggestion
if (!engineName.equals("hive") && !engineName.equals("iceberg")
&& partitionDesc != null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
