mymeiyi commented on code in PR #31259:
URL: https://github.com/apache/doris/pull/31259#discussion_r1515492828
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java:
##########
@@ -118,9 +123,9 @@ private void runInternal(ConnectContext ctx, StmtExecutor
executor) throws Excep
TableIf targetTableIf = InsertUtils.getTargetTable(logicalQuery, ctx);
// check auth
if (!Env.getCurrentEnv().getAccessManager()
- .checkTblPriv(ConnectContext.get(),
targetTableIf.getDatabase().getCatalog().getName(),
- targetTableIf.getDatabase().getFullName(),
targetTableIf.getName(),
- PrivPredicate.LOAD)) {
+ .checkTblPriv(ConnectContext.get(),
targetTableIf.getDatabase().getCatalog().getName(),
Review Comment:
remove unnecessary change
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java:
##########
@@ -152,14 +157,15 @@ private void runInternal(ConnectContext ctx, StmtExecutor
executor) throws Excep
if (physicalSink instanceof PhysicalOlapTableSink) {
if (GroupCommitInserter.groupCommit(ctx, sink, physicalSink)) {
- return;
+ // return;
+ throw new AnalysisException("group commit is not supported
in Nereids now");
}
OlapTable olapTable = (OlapTable) targetTableIf;
insertExecutor = new OlapInsertExecutor(ctx, olapTable, label,
planner, insertCtx);
boolean isEnableMemtableOnSinkNode =
- olapTable.getTableProperty().getUseSchemaLightChange()
- ?
insertExecutor.getCoordinator().getQueryOptions().isEnableMemtableOnSinkNode()
- : false;
+ olapTable.getTableProperty().getUseSchemaLightChange()
+ ?
insertExecutor.getCoordinator().getQueryOptions().isEnableMemtableOnSinkNode()
Review Comment:
remove unnecessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
