yangzhg commented on a change in pull request #6917:
URL: https://github.com/apache/incubator-doris/pull/6917#discussion_r736113793
##########
File path: be/src/util/bitmap_value.h
##########
@@ -1439,6 +1439,29 @@ class BitmapValue {
return ss.str();
}
+ /**
+ * Return new set with specified range (not include the range_end)
+ */
+ int64_t sub_range(const int64_t& range_start, const int64_t& range_end,
BitmapValue& ret_bitmap) {
Review comment:
```suggestion
int64_t sub_range(const int64_t& range_start, const int64_t& range_end,
BitmapValue* ret_bitmap) {
```
usually reference means const, mutable parameter use pointer
##########
File path: be/src/util/bitmap_value.h
##########
@@ -1439,6 +1439,29 @@ class BitmapValue {
return ss.str();
}
+ /**
+ * Return new set with specified range (not include the range_end)
+ */
+ int64_t sub_range(const int64_t& range_start, const int64_t& range_end,
BitmapValue& ret_bitmap) {
+ int64_t count = 0;
+ if (range_start >= range_end) {
+ return count;
+ }
Review comment:
already check in `bitmap_function.cpp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
