This is an automated email from the ASF dual-hosted git repository.
kxiao pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 08b0ef3dc81 [Bug](materialized-view) fix npe on create mv with star
(#31554) (#31911)
08b0ef3dc81 is described below
commit 08b0ef3dc81ec0e6b293cfa004f1ce6fca1a46a1
Author: Pxl <[email protected]>
AuthorDate: Thu Mar 7 18:55:24 2024 +0800
[Bug](materialized-view) fix npe on create mv with star (#31554) (#31911)
fix npe on create mv with star
---
.../java/org/apache/doris/analysis/CreateMaterializedViewStmt.java | 7 +++----
regression-test/suites/mv_p0/test_mv_useless/const_invalid.groovy | 5 +++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
index 446487a4232..911c9965555 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
@@ -186,6 +186,9 @@ public class CreateMaterializedViewStmt extends DdlStmt {
}
SelectList selectList = selectStmt.getSelectList();
for (SelectListItem selectListItem : selectList.getItems()) {
+ if (selectListItem.isStar()) {
+ throw new AnalysisException("The materialized view not support
select star");
+ }
checkExprValidInMv(selectListItem.getExpr());
}
}
@@ -266,10 +269,6 @@ public class CreateMaterializedViewStmt extends DdlStmt {
for (int i = 0; i < selectList.getItems().size(); i++) {
SelectListItem selectListItem = selectList.getItems().get(i);
- if (selectListItem.isStar()) {
- throw new AnalysisException("The materialized view not support
select star");
- }
-
Expr selectListItemExpr = selectListItem.getExpr();
if (!(selectListItemExpr instanceof SlotRef) &&
!(selectListItemExpr instanceof FunctionCallExpr)
&& !(selectListItemExpr instanceof ArithmeticExpr)) {
diff --git a/regression-test/suites/mv_p0/test_mv_useless/const_invalid.groovy
b/regression-test/suites/mv_p0/test_mv_useless/const_invalid.groovy
index 7d6f0d5cae1..1c6e6822f8d 100644
--- a/regression-test/suites/mv_p0/test_mv_useless/const_invalid.groovy
+++ b/regression-test/suites/mv_p0/test_mv_useless/const_invalid.groovy
@@ -43,4 +43,9 @@ suite ("const_invalid") {
sql "create materialized view const_3 as select k1,abs(1+1) from
d_table;"
exception "errCode = 2,"
}
+
+ test {
+ sql "create materialized view mvstar as select * from d_table;"
+ exception "errCode = 2,"
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
