morningman commented on a change in pull request #6866:
URL: https://github.com/apache/incubator-doris/pull/6866#discussion_r738540595
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -2185,6 +2185,7 @@ private void
materializeSlotForEmptyMaterializedTableRef(BaseTableRef tblRef, An
slot =
analyzer.getDescTbl().addSlotDescriptor(tblRef.getDesc());
slot.setColumn(minimuColumn);
slot.setIsMaterialized(true);
+ slot.setIsNullable(minimuColumn.isAllowNull());
Review comment:
What's this for? To fix bug?
##########
File path: be/src/olap/merger.cpp
##########
@@ -34,7 +34,7 @@ OLAPStatus Merger::merge_rowsets(TabletSharedPtr tablet,
ReaderType reader_type,
Merger::Statistics* stats_output) {
TRACE_COUNTER_SCOPE_LATENCY_US("merge_rowsets_latency_us");
- Reader reader;
+ TupleReader reader;
Review comment:
Why need to change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
