morningman commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-doris/pull/6964#discussion_r739638053
##########
File path: be/src/exprs/expr.cpp
##########
@@ -283,6 +283,9 @@ Status Expr::create_tree_from_thrift(ObjectPool* pool,
const std::vector<TExprNo
Expr* expr = NULL;
RETURN_IF_ERROR(create_expr(pool, nodes[*node_idx], &expr));
DCHECK(expr != NULL);
Review comment:
Here is the DCHECK here. So I think if expr is null here, this is a
fatal error?
Could you show me the case which can result in expr as null there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
