gavinchou commented on code in PR #32127:
URL: https://github.com/apache/doris/pull/32127#discussion_r1521175703
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy:
##########
@@ -92,21 +99,51 @@ class Config {
public TNetworkAddress feTargetThriftNetworkAddress
public TNetworkAddress syncerNetworkAddress
public InetSocketAddress feHttpInetSocketAddress
+ public InetSocketAddress feCloudHttpInetSocketAddress
public InetSocketAddress metaServiceHttpInetSocketAddress
+ public InetSocketAddress recycleServiceHttpInetSocketAddress
public Integer parallel
public Integer suiteParallel
public Integer actionParallel
public Integer times
public boolean withOutLoadData
+ public boolean isSmokeTest
+ public String multiClusterBes
+ public String metaServiceToken
+ public String multiClusterInstance
+ public String upgradeNewBeIp
+ public String upgradeNewBeHbPort
+ public String upgradeNewBeHttpPort
+ public String upgradeNewBeUniqueId
+
+ public String stageIamEndpoint
+ public String stageIamRegion
+ public String stageIamBucket
+ public String stageIamPolicy
+ public String stageIamRole
+ public String stageIamArn
+ public String stageIamAk
+ public String stageIamSk
+ public String stageIamUserId
+
+ public String clusterDir
+ public String kafkaBrokerList
+ public String cloudVersion
Config() {}
Config(String defaultDb, String jdbcUrl, String jdbcUser, String
jdbcPassword,
- String feSourceThriftAddress, String feTargetThriftAddress, String
feSyncerUser, String feSyncerPassword,
- String syncerPassword, String feHttpAddress, String feHttpUser,
String feHttpPassword, String metaServiceHttpAddress,
+ String feSourceThriftAddress, String feTargetThriftAddress, String
feSyncerUser, String feSyncerPassword, String syncerPassword,
Review Comment:
make it a arg per line ?
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy:
##########
@@ -92,21 +99,51 @@ class Config {
public TNetworkAddress feTargetThriftNetworkAddress
public TNetworkAddress syncerNetworkAddress
public InetSocketAddress feHttpInetSocketAddress
+ public InetSocketAddress feCloudHttpInetSocketAddress
public InetSocketAddress metaServiceHttpInetSocketAddress
+ public InetSocketAddress recycleServiceHttpInetSocketAddress
public Integer parallel
public Integer suiteParallel
public Integer actionParallel
public Integer times
public boolean withOutLoadData
+ public boolean isSmokeTest
+ public String multiClusterBes
+ public String metaServiceToken
+ public String multiClusterInstance
+ public String upgradeNewBeIp
+ public String upgradeNewBeHbPort
+ public String upgradeNewBeHttpPort
+ public String upgradeNewBeUniqueId
+
+ public String stageIamEndpoint
+ public String stageIamRegion
+ public String stageIamBucket
+ public String stageIamPolicy
+ public String stageIamRole
+ public String stageIamArn
+ public String stageIamAk
+ public String stageIamSk
+ public String stageIamUserId
+
+ public String clusterDir
+ public String kafkaBrokerList
+ public String cloudVersion
Config() {}
Config(String defaultDb, String jdbcUrl, String jdbcUser, String
jdbcPassword,
- String feSourceThriftAddress, String feTargetThriftAddress, String
feSyncerUser, String feSyncerPassword,
- String syncerPassword, String feHttpAddress, String feHttpUser,
String feHttpPassword, String metaServiceHttpAddress,
+ String feSourceThriftAddress, String feTargetThriftAddress, String
feSyncerUser, String feSyncerPassword, String syncerPassword,
Review Comment:
make it an arg per line ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
