morningman commented on code in PR #32340:
URL: https://github.com/apache/doris/pull/32340#discussion_r1527751608
##########
be/src/runtime/memory/lru_cache_policy.h:
##########
@@ -120,14 +120,17 @@ class LRUCachePolicy : public CachePolicy {
uint64_t new_id() { return _cache->new_id(); };
+ // Subclass can override this method to determine whether to do the minor
or full gc
Review Comment:
We are talking about the same thing
##########
be/src/util/obj_lru_cache.cpp:
##########
@@ -45,4 +45,11 @@ void ObjLRUCache::erase(const ObjKey& key) {
}
}
+bool ObjLRUCache::exceed_prune_limit() {
+ // just return true to prune all cached obj.
+ // Because ObjLRUCache is counted with number, not memory.
+ // Simple prune all
+ return true;
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
