github-actions[bot] commented on code in PR #32039:
URL: https://github.com/apache/doris/pull/32039#discussion_r1528341979
##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -83,33 +84,63 @@ MemTrackerLimiter::MemTrackerLimiter(Type type, const
std::string& label, int64_
if (_type == Type::LOAD || _type == Type::QUERY) {
_query_statistics = std::make_shared<QueryStatistics>();
}
+ g_memtrackerlimiter_cnt << 1;
+ tracker_limiter_group_it =
mem_tracker_limiter_pool[_group_num].trackers.end();
+}
+std::shared_ptr<MemTrackerLimiter>
MemTrackerLimiter::create_shared(MemTrackerLimiter::Type type,
Review Comment:
warning: method 'create_shared' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static std::shared_ptr<MemTrackerLimiter>
MemTrackerLimiter::create_shared(MemTrackerLimiter::Type type,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
