github-actions[bot] commented on code in PR #31827:
URL: https://github.com/apache/doris/pull/31827#discussion_r1528707653
##########
be/src/vec/columns/column_const.h:
##########
@@ -21,11 +21,10 @@
#pragma once
#include <glog/logging.h>
Review Comment:
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
```cpp
#include <glog/logging.h>
^
```
##########
be/src/vec/columns/column_const.h:
##########
@@ -199,22 +227,26 @@
size_t allocated_bytes() const override { return data->allocated_bytes() +
sizeof(s); }
- int compare_at(size_t, size_t, const IColumn& rhs, int nan_direction_hint)
const override {
- auto rhs_const_column = assert_cast<const ColumnConst&>(rhs);
+ int compare_at(size_t n, size_t m, const IColumn& rhs, int
nan_direction_hint) const override {
Review Comment:
warning: method 'compare_at' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static int compare_at(size_t n, size_t m, const IColumn& rhs, int
nan_direction_hint) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
