yiguolei commented on code in PR #32287:
URL: https://github.com/apache/doris/pull/32287#discussion_r1530022989
##########
be/src/vec/exprs/vexpr.cpp:
##########
@@ -542,9 +542,9 @@ void VExpr::close_function_context(VExprContext* context,
FunctionContext::Funct
if (_fn_context_index != -1) {
FunctionContext* fn_ctx = context->fn_context(_fn_context_index);
// close failed will make system unstable. dont swallow it.
- THROW_IF_ERROR(function->close(fn_ctx, FunctionContext::THREAD_LOCAL));
+ static_cast<void>(function->close(fn_ctx,
FunctionContext::THREAD_LOCAL));
if (scope == FunctionContext::FRAGMENT_LOCAL) {
- THROW_IF_ERROR(function->close(fn_ctx,
FunctionContext::FRAGMENT_LOCAL));
+ static_cast<void>(function->close(fn_ctx,
FunctionContext::FRAGMENT_LOCAL));
Review Comment:
Add try catch clause in VExprContext close method, we could catch all
exceptions and print log there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
