morningman commented on code in PR #32441:
URL: https://github.com/apache/doris/pull/32441#discussion_r1530126323
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetadataOps.java:
##########
@@ -186,6 +186,12 @@ public void commit(String dbName,
Table table = client.getTable(dbName, tableName);
HMSCommitter hmsCommitter = new HMSCommitter(this, fs, table);
hmsCommitter.commit(hivePUs);
+ ExternalDatabase<?> db = catalog.getDbNullable(dbName);
+ if (db == null) {
+ LOG.warn("Failed to get database: '" + dbName + "' in catalog: " +
catalog.getName());
+ } else {
+ db.setUnInitialized(true);
Review Comment:
2 questions:
1. Why refresh the db, not table?
2. Should call `env.getCatalogMgr().refreshExternalTable`, because the
refresh info need to sync to other FE via editlog.re
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -230,6 +231,8 @@ public class Coordinator implements CoordInterface {
private final List<TTabletCommitInfo> commitInfos = Lists.newArrayList();
private final List<TErrorTabletInfo> errorTabletInfos =
Lists.newArrayList();
+ private final List<THivePartitionUpdate> hivePartitionUpdates =
Lists.newArrayList();
Review Comment:
Add a TODO here, these should be moved to `ExternalTransactionMgr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
