github-actions[bot] commented on code in PR #32483:
URL: https://github.com/apache/doris/pull/32483#discussion_r1530143932
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -906,6 +915,8 @@ bool operator==(const TabletMeta& a, const TabletMeta& b) {
if (a._time_series_compaction_empty_rowsets_threshold !=
b._time_series_compaction_empty_rowsets_threshold)
return false;
+ if (a._time_series_compaction_level_threshold !=
b._time_series_compaction_level_threshold)
+ return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (a._time_series_compaction_level_threshold !=
b._time_series_compaction_level_threshold) {
return false;
}
```
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -288,7 +352,35 @@ void
TimeSeriesCumulativeCompactionPolicy::update_cumulative_point(
return;
}
+ if (tablet->tablet_meta()->time_series_compaction_level_threshold() >= 2 &&
+ output_rowset->rowset_meta()->compaction_level() < 2) {
+ return;
+ }
+
tablet->set_cumulative_layer_point(output_rowset->end_version() + 1);
}
+void TimeSeriesCumulativeCompactionPolicy::update_compaction_level(
Review Comment:
warning: method 'update_compaction_level' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void TimeSeriesCumulativeCompactionPolicy::update_compaction_level(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
