wangbo commented on code in PR #32554:
URL: https://github.com/apache/doris/pull/32554#discussion_r1533149083
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java:
##########
@@ -120,6 +128,20 @@ private WorkloadGroup(long id, String name, Map<String,
String> properties, long
this.cpuHardLimit = Integer.parseInt(cpuHardLimitStr);
this.properties.put(CPU_HARD_LIMIT, cpuHardLimitStr);
}
+ if (properties.containsKey(SPILL_THRESHOLD_LOW_WATERMARK)) {
+ String lowWatermarkStr =
properties.get(SPILL_THRESHOLD_LOW_WATERMARK);
+ if (lowWatermarkStr.endsWith("%")) {
+ lowWatermarkStr = lowWatermarkStr.substring(0,
lowWatermarkStr.length() - 1);
Review Comment:
Value check in WorkloadGroup.checkProperties.
What does 0 means?
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java:
##########
@@ -120,6 +128,20 @@ private WorkloadGroup(long id, String name, Map<String,
String> properties, long
this.cpuHardLimit = Integer.parseInt(cpuHardLimitStr);
this.properties.put(CPU_HARD_LIMIT, cpuHardLimitStr);
}
+ if (properties.containsKey(SPILL_THRESHOLD_LOW_WATERMARK)) {
+ String lowWatermarkStr =
properties.get(SPILL_THRESHOLD_LOW_WATERMARK);
+ if (lowWatermarkStr.endsWith("%")) {
+ lowWatermarkStr = lowWatermarkStr.substring(0,
lowWatermarkStr.length() - 1);
+ }
+ this.properties.put(SPILL_THRESHOLD_LOW_WATERMARK,
lowWatermarkStr);
+ }
+ if (properties.containsKey(SPILL_THRESHOLD_HIGH_WATERMARK)) {
+ String highWatermarkStr =
properties.get(SPILL_THRESHOLD_HIGH_WATERMARK);
+ if (highWatermarkStr.endsWith("%")) {
Review Comment:
Value check in WorkloadGroup.checkProperties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
