yiguolei commented on code in PR #32533:
URL: https://github.com/apache/doris/pull/32533#discussion_r1533200081
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -79,8 +79,8 @@ Status
DataTypeDateTimeV2SerDe::deserialize_one_cell_from_json(IColumn& column,
}
} else if (ReadBuffer rb(slice.data, slice.size);
- !read_datetime_v2_text_impl<UInt64>(val, rb)) {
- return Status::InvalidDataFormat("parse date fail, string: '{}'",
+ !read_datetime_v2_text_impl<UInt64>(val, rb, scale)) {
+ return Status::InvalidArgument("parse date fail, string: '{}'",
std::string(rb.position(),
rb.count()).c_str());
Review Comment:
why not pick related regression tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
