github-actions[bot] commented on code in PR #32630:
URL: https://github.com/apache/doris/pull/32630#discussion_r1533605865
##########
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##########
@@ -59,18 +59,28 @@ struct AggregateJavaUdafData {
AggregateJavaUdafData() = default;
AggregateJavaUdafData(int64_t num_args) { argument_size = num_args; }
- ~AggregateJavaUdafData() {
+ ~AggregateJavaUdafData() = default;
+
+ Status close_and_delete_object() {
Review Comment:
warning: method 'close_and_delete_object' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status close_and_delete_object() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
