yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1534069010
##########
be/src/vec/spill/spill_writer.cpp:
##########
@@ -35,13 +35,19 @@ Status SpillWriter::open() {
return Status::OK();
}
+SpillWriter::~SpillWriter() {
+ if (!closed_) {
+ LOG(WARNING) << "spill writer not closed correctly:\n" <<
boost::stacktrace::stacktrace();
Review Comment:
not use this way, boost has a static global lock.
Using doris::Status wrapped error stack, you could use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
