hust-hhb commented on code in PR #32200:
URL: https://github.com/apache/doris/pull/32200#discussion_r1534977055


##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1486,6 +1488,9 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) 
{
     @VariableMgr.VarAttr(name = ENABLE_UNIQUE_KEY_PARTIAL_UPDATE, needForward 
= true)
     public boolean enableUniqueKeyPartialUpdate = false;
 
+    @VariableMgr.VarAttr(name = ENABLE_AGG_KEY_PARTIAL_UPDATE, needForward = 
true)
+    public boolean enableAggregateKeyPartialUpdate = false;

Review Comment:
   For users, this is a new feature that should be controlled by a separate 
variable. If only use one variable to control them, may be the variable 
ENABLE_UNIQUE_KEY_PARTIAL_UPDATE should be change to ENABLE_PARTIAL_UPDATE, our 
documentation needs to be updated accordingly, and it may cause compatibility 
issues for users as their codes also need to be changed accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to