morningman commented on code in PR #32525:
URL: https://github.com/apache/doris/pull/32525#discussion_r1535017439
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateTableInfo.java:
##########
@@ -525,11 +525,16 @@ public void validate(ConnectContext ctx) {
}
}
+ /**
+ * validate ctas definition
+ */
public void validateCreateTableAsSelect(List<ColumnDefinition> columns,
ConnectContext ctx) {
this.columns = Utils.copyRequiredMutableList(columns);
// bucket num is hard coded 10 to be consistent with legacy planner
- this.distribution = new DistributionDescriptor(true, false, 10,
- Lists.newArrayList(columns.get(0).getName()));
+ if (engineName.equals("olap") && this.distribution == null) {
Review Comment:
We need check it strictly.
If engine name is not OLAP and distribution is not null, should throw
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
