github-actions[bot] commented on PR #32699:
URL: https://github.com/apache/doris/pull/32699#issuecomment-2014859145
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/8389388958";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 494:
if [[ -n "$BE_EXTENSION_IGNORE" ]]; then
^------------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
if [[ -n "${BE_EXTENSION_IGNORE}" ]]; then
In build.sh line 495:
IFS=',' read -r -a ignore_modules <<< "$BE_EXTENSION_IGNORE"
^------------------^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
IFS=',' read -r -a ignore_modules <<< "${BE_EXTENSION_IGNORE}"
In build.sh line 497:
modules=("${modules[@]/be-java-extensions\/$module}")
^-----^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
modules=("${modules[@]/be-java-extensions\/${module}}")
In build.sh line 781:
if [[ -n "$BE_EXTENSION_IGNORE" ]]; then
^------------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
if [[ -n "${BE_EXTENSION_IGNORE}" ]]; then
In build.sh line 782:
IFS=',' read -r -a ignore_modules <<< "$BE_EXTENSION_IGNORE"
^------------------^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
IFS=',' read -r -a ignore_modules <<< "${BE_EXTENSION_IGNORE}"
In build.sh line 786:
if [[ -n "$module" ]]; then
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ -n "${module}" ]]; then
In build.sh line 789:
if [[ "$module" == "$ignore_module" ]]; then
^-----^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^------------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
if [[ "${module}" == "${ignore_module}" ]]; then
In build.sh line 794:
if [[ "$ignore" -eq 0 ]]; then
^-----^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ "${ignore}" -eq 0 ]]; then
In build.sh line 795:
new_modules+=("$module")
^-----^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Did you mean:
new_modules+=("${module}")
For more information:
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -492,9 +492,9 @@
# If the BE_EXTENSION_IGNORE variable is not empty, remove the modules
that need to be ignored from FE_MODULES
if [[ -n "$BE_EXTENSION_IGNORE" ]]; then
- IFS=',' read -r -a ignore_modules <<< "$BE_EXTENSION_IGNORE"
+ IFS=',' read -r -a ignore_modules <<<"$BE_EXTENSION_IGNORE"
for module in "${ignore_modules[@]}"; do
- modules=("${modules[@]/be-java-extensions\/$module}")
+ modules=("${modules[@]/be-java-extensions\/$module/}")
done
fi
fi
@@ -779,7 +779,7 @@
extensions_modules+=("preload-extensions")
if [[ -n "$BE_EXTENSION_IGNORE" ]]; then
- IFS=',' read -r -a ignore_modules <<< "$BE_EXTENSION_IGNORE"
+ IFS=',' read -r -a ignore_modules <<<"$BE_EXTENSION_IGNORE"
new_modules=()
for module in "${extensions_modules[@]}"; do
module=${module// /}
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
