github-actions[bot] commented on code in PR #32673:
URL: https://github.com/apache/doris/pull/32673#discussion_r1535745790
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -247,6 +261,25 @@ class OperatorXBase : public OperatorBase {
return _row_descriptor;
}
+ // input expr -> intermediate_projections[0] ->
intermediate_projections[1] -> intermediate_projections[2] ... -> final
projections -> output expr
+ // prepare _row_descriptor intermediate_row_desc[0]
intermediate_row_desc[1] intermediate_row_desc.end()
_output_row_descriptor
+
+ [[nodiscard]] const RowDescriptor& projections_row_desc() const {
+ if (_intermediate_output_row_descriptor.empty()) {
+ return _row_descriptor;
+ } else {
+ return *_intermediate_output_row_descriptor.back();
+ }
+ }
+
+ [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) {
Review Comment:
warning: method 'intermediate_row_desc' can be made const
[readability-make-member-function-const]
```suggestion
[[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const {
```
##########
be/src/exec/exec_node.h:
##########
@@ -220,6 +220,26 @@ class ExecNode {
return _output_row_descriptor ? *_output_row_descriptor :
_row_descriptor;
}
virtual const RowDescriptor& intermediate_row_desc() const { return
_row_descriptor; }
+
+ // input expr -> intermediate_projections[0] ->
intermediate_projections[1] -> intermediate_projections[2] ... -> final
projections -> output expr
+ // prepare _row_descriptor intermediate_row_desc[0]
intermediate_row_desc[1] intermediate_row_desc.end()
_output_row_descriptor
+
+ [[nodiscard]] const RowDescriptor& projections_row_desc() const {
+ if (_intermediate_output_row_descriptor.empty()) {
+ return _row_descriptor;
+ } else {
+ return *_intermediate_output_row_descriptor.back();
+ }
+ }
+
+ [[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) {
Review Comment:
warning: method 'intermediate_row_desc' can be made const
[readability-make-member-function-const]
```suggestion
[[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
