This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 0945e4dda76 [fix](trino-connector) fix trino-connector log (#32498)
0945e4dda76 is described below

commit 0945e4dda76956489a15089177ec1cb86d522e5d
Author: Tiewei Fang <[email protected]>
AuthorDate: Mon Mar 25 23:42:14 2024 +0800

    [fix](trino-connector) fix trino-connector log (#32498)
    
    Trino uses java.util.logging as its log system, and will print a lot of 
logs to fe.out/be.out. Here is a redirect to a dedicated log file.
---
 .../doris/trinoconnector/TrinoConnectorPluginLoader.java | 15 +++++++++++++++
 .../trinoconnector/TrinoConnectorPluginLoader.java       | 16 ++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git 
a/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorPluginLoader.java
 
b/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorPluginLoader.java
index 134f315c333..1f08e28b005 100644
--- 
a/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorPluginLoader.java
+++ 
b/fe/be-java-extensions/trino-connector-scanner/src/main/java/org/apache/doris/trinoconnector/TrinoConnectorPluginLoader.java
@@ -30,6 +30,9 @@ import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
 import java.io.File;
+import java.util.logging.FileHandler;
+import java.util.logging.Level;
+import java.util.logging.SimpleFormatter;
 
 public class TrinoConnectorPluginLoader {
     private static final Logger LOG = 
LogManager.getLogger(TrinoConnectorPluginLoader.class);
@@ -42,6 +45,18 @@ public class TrinoConnectorPluginLoader {
 
         static {
             try {
+                // Trino uses jul as its own log system, so the attributes of 
JUL are configured here
+                System.setProperty("java.util.logging.SimpleFormatter.format",
+                        "%1$tY-%1$tm-%1$td %1$tH:%1$tM:%1$tS %4$s: 
%5$s%6$s%n");
+                java.util.logging.Logger logger = 
java.util.logging.Logger.getLogger("");
+                logger.setUseParentHandlers(false);
+                FileHandler fileHandler = new 
FileHandler(EnvUtils.getDorisHome() + "/log/trinoconnector%g.log",
+                        500000000, 10, true);
+                fileHandler.setLevel(Level.INFO);
+                fileHandler.setFormatter(new SimpleFormatter());
+                logger.addHandler(fileHandler);
+                java.util.logging.LogManager.getLogManager().addLogger(logger);
+
                 TypeOperators typeOperators = new TypeOperators();
                 featuresConfig = new FeaturesConfig();
                 TypeRegistry typeRegistry = new TypeRegistry(typeOperators, 
featuresConfig);
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/trinoconnector/TrinoConnectorPluginLoader.java
 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/trinoconnector/TrinoConnectorPluginLoader.java
index a0d34ffa31e..1e08c9effcb 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/trinoconnector/TrinoConnectorPluginLoader.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/trinoconnector/TrinoConnectorPluginLoader.java
@@ -18,6 +18,7 @@
 package org.apache.doris.datasource.trinoconnector;
 
 import org.apache.doris.common.Config;
+import org.apache.doris.common.EnvUtils;
 import org.apache.doris.trinoconnector.TrinoConnectorPluginManager;
 
 import com.google.common.util.concurrent.MoreExecutors;
@@ -31,6 +32,9 @@ import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
 import java.io.File;
+import java.util.logging.FileHandler;
+import java.util.logging.Level;
+import java.util.logging.SimpleFormatter;
 
 public class TrinoConnectorPluginLoader {
     private static final Logger LOG = 
LogManager.getLogger(TrinoConnectorPluginLoader.class);
@@ -44,6 +48,18 @@ public class TrinoConnectorPluginLoader {
 
         static {
             try {
+                // Trino uses jul as its own log system, so the attributes of 
JUL are configured here
+                System.setProperty("java.util.logging.SimpleFormatter.format",
+                        "%1$tY-%1$tm-%1$td %1$tH:%1$tM:%1$tS %4$s: 
%5$s%6$s%n");
+                java.util.logging.Logger logger = 
java.util.logging.Logger.getLogger("");
+                logger.setUseParentHandlers(false);
+                FileHandler fileHandler = new 
FileHandler(EnvUtils.getDorisHome() + "/log/trinoconnector%g.log",
+                        500000000, 10, true);
+                fileHandler.setLevel(Level.INFO);
+                fileHandler.setFormatter(new SimpleFormatter());
+                logger.addHandler(fileHandler);
+                java.util.logging.LogManager.getLogManager().addLogger(logger);
+
                 typeRegistry = new TypeRegistry(typeOperators, featuresConfig);
                 ServerPluginsProviderConfig serverPluginsProviderConfig = new 
ServerPluginsProviderConfig()
                         .setInstalledPluginsDir(new 
File(Config.trino_connector_plugin_dir));


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to