zhiqiang-hhhh commented on PR #31707: URL: https://github.com/apache/doris/pull/31707#issuecomment-2019293681
@rohitrs1983 Hello, thanks for your contribution. According to [mysql oct](https://dev.mysql.com/doc/refman/8.3/en/string-functions.html#function_oct), this function only receive BigInt argugment, as for string input, we can generate a cast expr by planner, so this function can just be focus on BigInt input, no need to be a variadic function. BTW, add some be ut pls ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
