morrySnow commented on code in PR #32746:
URL: https://github.com/apache/doris/pull/32746#discussion_r1538802828
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##########
@@ -122,7 +122,7 @@ public class FunctionCallExpr extends Expr {
Preconditions.checkArgument(children.get(1) instanceof
IntLiteral
|| (children.get(1) instanceof CastExpr
&& children.get(1).getChild(0) instanceof
IntLiteral),
- "2nd argument of function round/floor/ceil/truncate
must be literal");
+ "2nd argument of function round/floor/ceil must be
literal");
Review Comment:
why not support all round family function? if truncate support slot as 2nd
arg, other round family function should support this feature too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]