morrySnow commented on code in PR #32685:
URL: https://github.com/apache/doris/pull/32685#discussion_r1538805613
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java:
##########
@@ -69,8 +69,15 @@
* The abstract class for all materialized view rules
*/
public abstract class AbstractMaterializedViewRule implements
ExplorationRuleFactory {
- public static final HashSet<JoinType> SUPPORTED_JOIN_TYPE_SET =
Sets.newHashSet(JoinType.INNER_JOIN,
- JoinType.LEFT_OUTER_JOIN);
+ public static final HashSet<JoinType> SUPPORTED_JOIN_TYPE_SET =
Sets.newHashSet(
Review Comment:
nit: it is better use ImmutableSet
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/HyperGraphComparator.java:
##########
@@ -73,7 +73,7 @@ public class HyperGraphComparator {
private final Map<Edge, List<? extends Expression>>
pullUpQueryExprWithEdge = new HashMap<>();
private final Map<Edge, List<? extends Expression>> pullUpViewExprWithEdge
= new HashMap<>();
private final LogicalCompatibilityContext logicalCompatibilityContext;
- private final Map<JoinEdge, Pair<JoinType, Set<Slot>>>
inferredViewEdgeWithCond = new HashMap<>();
+ private final Map<JoinEdge, Pair<JoinType, Set<Set<Slot>>>>
inferredViewEdgeWithCond = new HashMap<>();
Review Comment:
could u add some comment later to explain what mean about all variable's key
and value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
