github-actions[bot] commented on code in PR #32839:
URL: https://github.com/apache/doris/pull/32839#discussion_r1538910720
##########
be/src/olap/column_mapping.h:
##########
@@ -27,16 +27,18 @@ namespace doris {
class WrapperField;
struct ColumnMapping {
- ColumnMapping() : ref_column(-1), default_value(nullptr) {}
+ ColumnMapping() = default;
virtual ~ColumnMapping() = default;
+ bool has_reference() const { return expr != nullptr || ref_column >= 0; }
Review Comment:
warning: function 'has_reference' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool has_reference() const { return expr != nullptr ||
ref_column >= 0; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
