yiguolei commented on code in PR #32871:
URL: https://github.com/apache/doris/pull/32871#discussion_r1540283596
##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_function.groovy:
##########
@@ -734,4 +734,17 @@ suite("test_date_function") {
(
SELECT FROM_UNIXTIME(UNIX_TIMESTAMP('20230918', '%Y%m%d'),
'yyyy-MM-dd HH:mm:ss') AS `a`
)t """
+
+ sql """
+ create table date_varchar(
+ dt varchar null,
+ fmt varchar null
+ )
+ DISTRIBUTED BY HASH(`dt`) BUCKETS 1
+ properties("replication_num" = "1");
+ """
+ sql """ insert into date_varchar values ("2020-12-12", "%Y-%m-%d"),
("20201111", "%Y%m%d"), ("202012-13", "%Y%m-%d"); """
Review Comment:
also test some invalid values like 0000-00-00, and some very large values
9999-12-31 .
And also test the format value for example %Y%m%d or yyyy-mm-dd or other
invalid values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
