github-actions[bot] commented on code in PR #32914:
URL: https://github.com/apache/doris/pull/32914#discussion_r1540958196
##########
be/src/olap/task/engine_task.h:
##########
@@ -27,13 +27,18 @@
namespace doris {
+class MemTrackerLimiter;
+
// base class for storage engine
// add "Engine" as task prefix to prevent duplicate name with agent task
class EngineTask {
public:
virtual ~EngineTask() = default;
virtual Status execute() { return Status::OK(); }
virtual Status finish() { return Status::OK(); }
+ std::shared_ptr<MemTrackerLimiter> mem_tracker() const { return
_mem_tracker; }
Review Comment:
warning: function 'mem_tracker' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] std::shared_ptr<MemTrackerLimiter> mem_tracker() const {
return _mem_tracker; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
