yiguolei commented on code in PR #32931:
URL: https://github.com/apache/doris/pull/32931#discussion_r1542202070
##########
be/src/pipeline/exec/partitioned_aggregation_sink_operator.cpp:
##########
@@ -170,6 +170,9 @@ Status
PartitionedAggSinkOperatorX::sink(doris::RuntimeState* state, vectorized:
if (revocable_mem_size(state) > 0) {
RETURN_IF_ERROR(revoke_memory(state));
} else {
+ for (auto& partition :
local_state._shared_state->spill_partitions) {
Review Comment:
There are some problems:
1. this API will write disk, it may blocking pipeline thread.
2. If eos and revoable mem size == 0, why do we need finish current
spilling, since there are no data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
