This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 234594379b5 [fix](jni) avoid coredump if failed to get jni env
(#32950) (#33012)
234594379b5 is described below
commit 234594379b59723ce44c80f7867262a3b6eb4888
Author: Mingyu Chen <[email protected]>
AuthorDate: Fri Mar 29 13:47:46 2024 +0800
[fix](jni) avoid coredump if failed to get jni env (#32950) (#33012)
bp #32950
---
be/src/vec/exec/jni_connector.cpp | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/be/src/vec/exec/jni_connector.cpp
b/be/src/vec/exec/jni_connector.cpp
index 5c85e329022..7ad6761523d 100644
--- a/be/src/vec/exec/jni_connector.cpp
+++ b/be/src/vec/exec/jni_connector.cpp
@@ -58,11 +58,7 @@ namespace doris::vectorized {
M(TypeIndex::Float64, Float64)
JniConnector::~JniConnector() {
- Status st = close();
- if (!st.ok()) {
- // Ensure successful resource release
- LOG(FATAL) << "Failed to release jni resource: " << st.to_string();
- }
+ static_cast<void>(close());
}
Status JniConnector::open(RuntimeState* state, RuntimeProfile* profile) {
@@ -200,8 +196,9 @@ Status JniConnector::close() {
_closed = true;
jthrowable exc = (env)->ExceptionOccurred();
if (exc != nullptr) {
- LOG(WARNING) << "Failed to release jni resource: "
- << JniUtil::GetJniExceptionMsg(env).to_string();
+ // Ensure successful resource release
+ LOG(FATAL) << "Failed to release jni resource: "
+ << JniUtil::GetJniExceptionMsg(env).to_string();
}
}
return Status::OK();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
