morningman commented on a change in pull request #7167: URL: https://github.com/apache/incubator-doris/pull/7167#discussion_r756975635
########## File path: bin/doris_be.sh ########## @@ -0,0 +1,76 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +export DORIS_HOME=`cd "$curdir"; pwd` +export PID_DIR=`cd "$curdir"; pwd` +function start() { + echo "Starting Apache Doris Frontend" + sh $DORIS_HOME/bin/start_be.sh --daemon + if [ -f "$DORIS_HOME/bin/be.pid" ]; then + echo "Apache Doris Backend start fail!" + else + sleep 1s + pid=`cat $DORIS_HOME/bin/be.pid` + echo "Doris Be pid : ${pid}" + echo "Apache Doris Backend start success!" + fi +} + +function stop() { + echo "stop Apache Doris Frontend" Review comment: ```suggestion echo "stop Apache Doris Backend" ``` ########## File path: bin/doris_be.sh ########## @@ -0,0 +1,76 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +export DORIS_HOME=`cd "$curdir"; pwd` +export PID_DIR=`cd "$curdir"; pwd` +function start() { + echo "Starting Apache Doris Frontend" Review comment: ```suggestion echo "Starting Apache Doris Backend" ``` ########## File path: build.sh ########## @@ -327,6 +327,7 @@ if [ ${BUILD_BE} -eq 1 ]; then ${DORIS_OUTPUT}/udf/include cp -r -p ${DORIS_HOME}/be/output/bin/* ${DORIS_OUTPUT}/be/bin/ + cp -r -p ${DORIS_HOME}/bin/doris_be.sh ${DORIS_OUTPUT}/be/bin/ Review comment: missing FE? ########## File path: bin/doris_be.sh ########## @@ -0,0 +1,76 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +export DORIS_HOME=`cd "$curdir"; pwd` +export PID_DIR=`cd "$curdir"; pwd` +function start() { + echo "Starting Apache Doris Frontend" + sh $DORIS_HOME/bin/start_be.sh --daemon + if [ -f "$DORIS_HOME/bin/be.pid" ]; then + echo "Apache Doris Backend start fail!" + else + sleep 1s + pid=`cat $DORIS_HOME/bin/be.pid` + echo "Doris Be pid : ${pid}" + echo "Apache Doris Backend start success!" Review comment: ```suggestion echo "Apache Doris Backend successfully started!" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
