morningman commented on a change in pull request #7183:
URL: https://github.com/apache/incubator-doris/pull/7183#discussion_r757006435
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/DateLiteral.java
##########
@@ -361,8 +368,18 @@ public int compareLiteral(LiteralExpr expr) {
if (expr == MaxLiteral.MAX_VALUE) {
return -1;
}
+
+ long thisExprLongValue = getLongValue();
+ long otherExprLongValue = expr.getLongValue();
+ if (!getType().equals(expr.getType())) {
+ if (getType().equals(Type.DATE)) {
Review comment:
Are you sure the `expr` is either `DATE` or `DATETIME` type?
May it be a Long value? for example.
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/qe/cache/PartitionRange.java
##########
@@ -48,6 +48,8 @@
import java.util.List;
import java.util.Map;
+import static org.apache.doris.analysis.DateLiteral.BASIC_ZERO_TIME;
Review comment:
not using static import:
http://doris.incubator.apache.org/master/zh-CN/developer-guide/java-format-code.html#import-order
##########
File path: fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
##########
@@ -17,6 +17,7 @@
package org.apache.doris.planner;
+import com.google.common.base.Splitter;
Review comment:
import order:
http://doris.incubator.apache.org/master/zh-CN/developer-guide/java-format-code.html#import-order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
