github-actions[bot] commented on code in PR #33076:
URL: https://github.com/apache/doris/pull/33076#discussion_r1545579460
##########
be/src/http/action/compaction_action.cpp:
##########
@@ -278,6 +279,23 @@ Status
CompactionAction::_execute_compaction_callback(TabletSharedPtr tablet,
<< ", table=" << tablet->tablet_id();
}
}
+ } else if (compaction_type == PARAM_COMPACTION_REMOTE) {
+ do {
+ if
(!tablet->tablet_meta()->tablet_schema()->enable_single_replica_compaction()) {
+ res = Status::Cancelled("tablet is not enable single replica
compaction");
+ break;
+ }
+ if (!_engine.should_fetch_from_peer(tablet->tablet_id())) {
+ res = Status::Cancelled("tablet should do compaction locally");
+ break;
+ }
+ SingleReplicaCompaction single_compaction(_engine, tablet);
+ res = do_compact(single_compaction);
+ if (!res) {
+ LOG(WARNING) << "failed to do single replica compaction. res="
<< res
+ << ", table=" << tablet->tablet_id();
+ }
+ } while (0);
Review Comment:
warning: converting integer literal to bool, use bool literal instead
[modernize-use-bool-literals]
```suggestion
} while (false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
