xinghuayu007 commented on a change in pull request #7149:
URL: https://github.com/apache/incubator-doris/pull/7149#discussion_r758023835



##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/TableProperty.java
##########
@@ -137,6 +151,11 @@ public void modifyTableProperties(Map<String, String> 
modifyProperties) {
         properties.putAll(modifyProperties);
     }
 
+    public void modifyTableProperties(DataSortInfo dataSortInfo) {

Review comment:
       modifyTableProperties keeps the same style with before

##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
##########
@@ -514,4 +516,43 @@ public static ReplicaAllocation 
analyzeReplicaAllocation(Map<String, String> pro
         }
         return replicaAlloc;
     }
+
+    public static DataSortInfo analyzeDataSortInfo(Map<String, String> 
properties, KeysType keyType,
+                                                   int keyCount, 
TStorageFormat storageFormat) throws AnalysisException {
+        if (properties == null || properties.isEmpty()) {
+            return new DataSortInfo(TSortType.LEXICAL, keyCount);
+        }
+        String sortMethod = "lexical";

Review comment:
       done

##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
##########
@@ -514,4 +516,43 @@ public static ReplicaAllocation 
analyzeReplicaAllocation(Map<String, String> pro
         }
         return replicaAlloc;
     }
+
+    public static DataSortInfo analyzeDataSortInfo(Map<String, String> 
properties, KeysType keyType,
+                                                   int keyCount, 
TStorageFormat storageFormat) throws AnalysisException {
+        if (properties == null || properties.isEmpty()) {
+            return new DataSortInfo(TSortType.LEXICAL, keyCount);
+        }
+        String sortMethod = "lexical";
+        if (properties.containsKey(DataSortInfo.DATA_SORT_TYPE)) {
+            sortMethod = properties.remove(DataSortInfo.DATA_SORT_TYPE);
+        }
+        TSortType sortType = TSortType.LEXICAL;
+        if (sortMethod.equalsIgnoreCase("zorder")) {

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to