github-actions[bot] commented on code in PR #33127:
URL: https://github.com/apache/doris/pull/33127#discussion_r1546343554
##########
be/test/vec/core/block_test.cpp:
##########
@@ -165,7 +165,7 @@ void
serialize_and_deserialize_test(segment_v2::CompressionTypePB compression_ty
decimal_column.get())
->get_data();
for (int i = 0; i < 1024; ++i) {
- __int128_t value = i * pow(10, 9) + i * pow(10, 8);
+ __int128_t value = __int128_t(i * pow(10, 9) + i * pow(10, 8));
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
auto value = __int128_t(i * pow(10, 9) + i * pow(10, 8));
```
##########
be/test/vec/core/block_test.cpp:
##########
@@ -322,7 +322,7 @@
decimal_column.get())
->get_data();
for (int i = 0; i < 1024; ++i) {
- __int128_t value = i * pow(10, 9) + i * pow(10, 8);
+ __int128_t value = __int128_t(i * pow(10, 9) + i * pow(10, 8));
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
auto value = __int128_t(i * pow(10, 9) + i * pow(10, 8));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
