xiaokang commented on code in PR #33130:
URL: https://github.com/apache/doris/pull/33130#discussion_r1547104321
##########
be/src/vec/columns/column_array.h:
##########
@@ -219,7 +220,7 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
const uint32_t* indices_end) override;
void replace_column_data(const IColumn& rhs, size_t row, size_t self_row =
0) override {
- DCHECK(size() > self_row);
+ DCHECK(self_row != 0 && size() == self_row + 1);
Review Comment:
should be DCHECK(self_row == 0 || (self_row != 0 && size() == self_row + 1))
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
