github-actions[bot] commented on code in PR #33165:
URL: https://github.com/apache/doris/pull/33165#discussion_r1547467369
##########
be/src/vec/sink/load_stream_stub_pool.cpp:
##########
@@ -63,10 +63,23 @@
return streams;
}
+void LoadStreamStubPool::inc_closed_sink_count(PUniqueId load_id) {
+ UniqueId id(load_id);
+ _closed_sink_count[id]++;
+}
+
+int LoadStreamStubPool::get_closed_sink_count(PUniqueId load_id) {
Review Comment:
warning: method 'get_closed_sink_count' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static int LoadStreamStubPool::get_closed_sink_count(PUniqueId load_id) {
```
##########
be/src/vec/sink/load_stream_stub_pool.cpp:
##########
@@ -63,10 +63,23 @@ std::shared_ptr<LoadStreams>
LoadStreamStubPool::get_or_create(PUniqueId load_id
return streams;
}
+void LoadStreamStubPool::inc_closed_sink_count(PUniqueId load_id) {
Review Comment:
warning: method 'inc_closed_sink_count' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void LoadStreamStubPool::inc_closed_sink_count(PUniqueId load_id) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
