platoneko commented on code in PR #33168:
URL: https://github.com/apache/doris/pull/33168#discussion_r1548058442
##########
be/src/olap/compaction.h:
##########
@@ -65,8 +65,15 @@ class Compaction {
virtual std::string_view compaction_name() const = 0;
protected:
+ // Convert `_tablet` from `BaseTablet` to `Tablet`
+ Tablet* tablet();
Review Comment:
不建议在 cloud 和 local 的公用基类做强转
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
