924060929 commented on code in PR #32743:
URL: https://github.com/apache/doris/pull/32743#discussion_r1548999799
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalProject.java:
##########
@@ -58,6 +59,7 @@ public class LogicalProject<CHILD_TYPE extends Plan> extends
LogicalUnary<CHILD_
private final List<NamedExpression> excepts;
private final boolean isDistinct;
private final boolean canEliminate;
+ private List<BoundStar> boundStars = Lists.newArrayList();
Review Comment:
should be immutable
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalCatalogRelation.java:
##########
@@ -59,6 +60,7 @@ public abstract class LogicalCatalogRelation extends
LogicalRelation implements
protected final TableIf table;
// [catalogName, databaseName]
protected final ImmutableList<String> qualifier;
+ private Pair<Integer, Integer> indexInSqlString;
Review Comment:
should be immutable
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/BoundStar.java:
##########
@@ -17,33 +17,73 @@
package org.apache.doris.nereids.trees.expressions;
+import org.apache.doris.common.Pair;
import org.apache.doris.nereids.analyzer.UnboundSlot;
import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
import java.util.List;
+import java.util.Set;
import java.util.stream.Collectors;
/** BoundStar is used to wrap list of slots for temporary. */
public class BoundStar extends NamedExpression implements PropagateNullable {
+ private Pair<Integer, Integer> indexInSqlString;
Review Comment:
should be immutable
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalCatalogRelation.java:
##########
@@ -59,6 +60,7 @@ public abstract class LogicalCatalogRelation extends
LogicalRelation implements
protected final TableIf table;
// [catalogName, databaseName]
protected final ImmutableList<String> qualifier;
+ private Pair<Integer, Integer> indexInSqlString;
Review Comment:
add comment for the key and value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
