github-actions[bot] commented on code in PR #32867:
URL: https://github.com/apache/doris/pull/32867#discussion_r1549440419
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -88,5 +88,33 @@ Status
DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
return Status::OK();
}
+Status DataTypeIPv4SerDe::write_column_to_pb(const IColumn& column, PValues&
result, int start,
Review Comment:
warning: method 'write_column_to_pb' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:91:
```diff
- int end) const {
+ int end) {
```
be/src/vec/data_types/serde/data_type_ipv4_serde.h:52:
```diff
- Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
- int end) const override;
+ static Status write_column_to_pb(const IColumn& column, PValues&
result, int start,
+ int end) override;
```
##########
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:
##########
@@ -240,5 +240,32 @@ Status
DataTypeJsonbSerDe::read_one_cell_from_json(IColumn& column,
return Status::OK();
}
+Status DataTypeJsonbSerDe::write_column_to_pb(const IColumn& column, PValues&
result, int start,
Review Comment:
warning: method 'write_column_to_pb' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:243:
```diff
- int end) const {
+ int end) {
```
be/src/vec/data_types/serde/data_type_jsonb_serde.h:67:
```diff
- Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
- int end) const override;
+ static Status write_column_to_pb(const IColumn& column, PValues&
result, int start,
+ int end) override;
```
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -88,5 +88,33 @@
return Status::OK();
}
+Status DataTypeIPv4SerDe::write_column_to_pb(const IColumn& column, PValues&
result, int start,
+ int end) const {
+ const auto& column_data = assert_cast<const ColumnIPv4&>(column);
+ result.mutable_string_value()->Reserve(end - start);
+ auto* ptype = result.mutable_type();
+ ptype->set_id(PGenericType::IPV4);
+ for (int i = start; i < end; ++i) {
+ IPv4Value ipv4_value(column_data.get_data()[i]);
+ result.add_string_value(ipv4_value.to_string());
+ }
+ return Status::OK();
+}
+
+Status DataTypeIPv4SerDe::read_column_from_pb(IColumn& column, const PValues&
arg) const {
Review Comment:
warning: method 'read_column_from_pb' can be made static
[readability-convert-member-functions-to-static]
```suggestion
Status DataTypeIPv4SerDe::read_column_from_pb(IColumn& column, const
PValues& arg) {
```
be/src/vec/data_types/serde/data_type_ipv4_serde.h:54:
```diff
- Status read_column_from_pb(IColumn& column, const PValues& arg) const
override;
+ static Status read_column_from_pb(IColumn& column, const PValues& arg)
override;
```
##########
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:
##########
@@ -240,5 +240,32 @@
return Status::OK();
}
+Status DataTypeJsonbSerDe::write_column_to_pb(const IColumn& column, PValues&
result, int start,
+ int end) const {
+ const auto& string_column = assert_cast<const ColumnString&>(column);
+ result.mutable_string_value()->Reserve(end - start);
+ auto* ptype = result.mutable_type();
+ ptype->set_id(PGenericType::JSONB);
+ for (size_t row_num = start; row_num < end; ++row_num) {
+ std::string_view string_ref =
string_column.get_data_at(row_num).to_string_view();
+ std::string json_string =
+ JsonbToJson::jsonb_to_json_string(string_ref.data(),
string_ref.size());
+ result.add_string_value(json_string);
+ }
+ return Status::OK();
+}
+
+Status DataTypeJsonbSerDe::read_column_from_pb(IColumn& column, const PValues&
arg) const {
Review Comment:
warning: method 'read_column_from_pb' can be made static
[readability-convert-member-functions-to-static]
```suggestion
Status DataTypeJsonbSerDe::read_column_from_pb(IColumn& column, const
PValues& arg) {
```
be/src/vec/data_types/serde/data_type_jsonb_serde.h:69:
```diff
- Status read_column_from_pb(IColumn& column, const PValues& arg) const
override;
+ static Status read_column_from_pb(IColumn& column, const PValues& arg)
override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
