This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git
commit 113bada7edddeee778b80cf81af0d8f4baed94bd Author: Pxl <[email protected]> AuthorDate: Mon Apr 1 15:46:54 2024 +0800 [Chore](runtime-filter) add check is broadcast on nlj (#33088) add check is broadcast on nlj --- be/src/pipeline/exec/nested_loop_join_build_operator.cpp | 5 +++++ fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilter.java | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/be/src/pipeline/exec/nested_loop_join_build_operator.cpp b/be/src/pipeline/exec/nested_loop_join_build_operator.cpp index f074afce374..52b27f03b5f 100644 --- a/be/src/pipeline/exec/nested_loop_join_build_operator.cpp +++ b/be/src/pipeline/exec/nested_loop_join_build_operator.cpp @@ -44,6 +44,11 @@ Status NestedLoopJoinBuildSinkLocalState::init(RuntimeState* state, LocalSinkSta for (size_t i = 0; i < p._runtime_filter_descs.size(); i++) { RETURN_IF_ERROR(state->register_producer_runtime_filter( p._runtime_filter_descs[i], p._need_local_merge, &_runtime_filters[i], false)); + if (!_runtime_filters[i]->is_broadcast_join()) { + return Status::InternalError( + "runtime filter({}) on NestedLoopJoin should be set to is_broadcast_join,", + _runtime_filters[i]->get_name()); + } } return Status::OK(); } diff --git a/fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilter.java b/fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilter.java index 00117beae72..a049079ccd4 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilter.java +++ b/fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilter.java @@ -685,7 +685,7 @@ public final class RuntimeFilter { if (node instanceof HashJoinNode) { setIsBroadcast(((HashJoinNode) node).getDistributionMode() == HashJoinNode.DistributionMode.BROADCAST); } else { - setIsBroadcast(false); + setIsBroadcast(true); } if (LOG.isTraceEnabled()) { LOG.trace("Runtime filter: " + debugString()); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
