github-actions[bot] commented on code in PR #33025:
URL: https://github.com/apache/doris/pull/33025#discussion_r1549632863
##########
be/src/olap/merger.cpp:
##########
@@ -315,25 +315,82 @@
}
// for segcompaction
-Status Merger::vertical_compact_one_group(int64_t tablet_id, ReaderType
reader_type,
- const TabletSchema& tablet_schema,
bool is_key,
- const std::vector<uint32_t>&
column_group,
- vectorized::RowSourcesBuffer*
row_source_buf,
- vectorized::VerticalBlockReader&
src_block_reader,
- segment_v2::SegmentWriter&
dst_segment_writer,
- int64_t max_rows_per_segment,
Statistics* stats_output,
- uint64_t* index_size, KeyBoundsPB&
key_bounds) {
+Status Merger::vertical_compact_one_group(
Review Comment:
warning: function 'vertical_compact_one_group' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status Merger::vertical_compact_one_group(int64_t tablet_id, ReaderType
reader_type,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/merger.cpp:317:** 105 lines including whitespace and comments
(threshold 80)
```cpp
Status Merger::vertical_compact_one_group(int64_t tablet_id, ReaderType
reader_type,
^
```
</details>
##########
be/src/olap/merger.cpp:
##########
@@ -315,25 +315,82 @@ Status Merger::vertical_compact_one_group(
}
// for segcompaction
-Status Merger::vertical_compact_one_group(int64_t tablet_id, ReaderType
reader_type,
- const TabletSchema& tablet_schema,
bool is_key,
- const std::vector<uint32_t>&
column_group,
- vectorized::RowSourcesBuffer*
row_source_buf,
- vectorized::VerticalBlockReader&
src_block_reader,
- segment_v2::SegmentWriter&
dst_segment_writer,
- int64_t max_rows_per_segment,
Statistics* stats_output,
- uint64_t* index_size, KeyBoundsPB&
key_bounds) {
+Status Merger::vertical_compact_one_group(
Review Comment:
warning: method 'vertical_compact_one_group' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status Merger::vertical_compact_one_group(int64_t tablet_id,
ReaderType reader_type,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
