yiguolei commented on code in PR #33229:
URL: https://github.com/apache/doris/pull/33229#discussion_r1549802445
##########
be/src/pipeline/exec/spill_sort_source_operator.cpp:
##########
@@ -91,29 +92,39 @@ Status
SpillSortLocalState::initiate_merge_sort_spill_streams(RuntimeState* stat
auto spill_func = [this, state, &parent, execution_context, submit_timer] {
auto execution_context_lock = execution_context.lock();
if (!execution_context_lock) {
- LOG(INFO) << "execution_context released, maybe query was
cancelled.";
+ LOG(INFO) << "query " << print_id(state->query_id())
+ << " execution_context released, maybe query was
cancelled.";
return Status::OK();
}
_spill_wait_in_queue_timer->update(submit_timer.elapsed_time());
SCOPED_TIMER(_spill_merge_sort_timer);
SCOPED_ATTACH_TASK(state);
Defer defer {[&]() {
- if (!_status.ok()) {
- LOG(WARNING) << "sort node " << _parent->node_id()
- << " merge spill data error: " << _status;
+ if (!_status.ok() || state->is_cancelled()) {
+ if (!_status.ok()) {
+ LOG(WARNING) << "query " << print_id(state->query_id()) <<
" sort node "
+ << _parent->node_id() << " merge spill data
error: " << _status;
+ }
+ _shared_state->close();
Review Comment:
我感觉不需要调用这个，因为析构函数里会自动删除。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
