github-actions[bot] commented on code in PR #33250:
URL: https://github.com/apache/doris/pull/33250#discussion_r1551018567
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -208,7 +208,7 @@ void CloudTabletMgr::erase_tablet(int64_t tablet_id) {
_cache->erase(key);
}
-void CloudTabletMgr::vacuum_stale_rowsets() {
+void CloudTabletMgr::vacuum_stale_rowsets(const CountDownLatch& stop_latch) {
Review Comment:
warning: method 'vacuum_stale_rowsets' can be made static
[readability-convert-member-functions-to-static]
be/src/cloud/cloud_tablet_mgr.h:44:
```diff
- void vacuum_stale_rowsets(const CountDownLatch& stop_latch);
+ static void vacuum_stale_rowsets(const CountDownLatch& stop_latch);
```
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -231,7 +235,7 @@
return weak_tablets;
}
-void CloudTabletMgr::sync_tablets() {
+void CloudTabletMgr::sync_tablets(const CountDownLatch& stop_latch) {
Review Comment:
warning: method 'sync_tablets' can be made static
[readability-convert-member-functions-to-static]
be/src/cloud/cloud_tablet_mgr.h:50:
```diff
- void sync_tablets(const CountDownLatch& stop_latch);
+ static void sync_tablets(const CountDownLatch& stop_latch);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
