github-actions[bot] commented on code in PR #33272:
URL: https://github.com/apache/doris/pull/33272#discussion_r1553771820
##########
be/src/vec/functions/function_string.h:
##########
@@ -294,6 +294,62 @@ struct SubstringUtil {
}
};
+class FunctionStrcmp : public IFunction {
+public:
+ static constexpr auto name = "strcmp";
+
+ static FunctionPtr create() { return std::make_shared<FunctionStrcmp>(); }
+
+ String get_name() const override { return name; }
+
+ size_t get_number_of_arguments() const override { return 2; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
Review Comment:
warning: method 'get_return_type_impl' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataTypePtr get_return_type_impl(const DataTypes& arguments)
override {
```
##########
be/src/vec/functions/function_string.h:
##########
@@ -294,6 +294,62 @@
}
};
+class FunctionStrcmp : public IFunction {
+public:
+ static constexpr auto name = "strcmp";
+
+ static FunctionPtr create() { return std::make_shared<FunctionStrcmp>(); }
+
+ String get_name() const override { return name; }
+
+ size_t get_number_of_arguments() const override { return 2; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeInt16>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
Review Comment:
warning: method 'execute_impl' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
size_t result, size_t input_rows_count) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
