morningman commented on a change in pull request #7276:
URL: https://github.com/apache/incubator-doris/pull/7276#discussion_r763052776
##########
File path: docs/.vuepress/sidebar/zh-CN.js
##########
@@ -636,8 +636,9 @@ module.exports = [
"java-format-code",
"cpp-format-code",
"How-to-Share-blogs",
- "commit-format-specification",
- "minidump"
+ "commit-format-specification",
+ "minidump",
+ "bitmap-hll-file-format",
Review comment:
No same order as en doc?
##########
File path: be/src/runtime/mysql_result_writer.cpp
##########
@@ -115,7 +115,18 @@ int MysqlResultWriter::_add_row_value(int index, const
TypeDescriptor& type, voi
case TYPE_HLL:
case TYPE_OBJECT: {
- buf_ret = _row_buffer->push_null();
+ if (_output_object_data) {
+ const StringValue* string_val = (const StringValue*)(item);
+
+ if (string_val->ptr == nullptr) {
Review comment:
using string_val->is_null?
##########
File path: docs/en/administrator-guide/variables.md
##########
@@ -443,3 +443,6 @@ Translated with www.DeepL.com/Translator (free version)
* `disable_join_reorder`
Used to turn off all automatic join reorder algorithms in the system.
There are two values: true and false.It is closed by default, that is, the
automatic join reorder algorithm of the system is adopted. After set to true,
the system will close all automatic sorting algorithms, adopt the original SQL
table order, and execute join
+
+* `show_object_data`
Review comment:
how about `return_object_data_as_binary`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
