HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554852365
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -87,6 +87,33 @@ Status
DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
column_data.insert_value(val);
return Status::OK();
}
+Status DataTypeIPv4SerDe::write_column_to_pb(const IColumn& column, PValues&
result, int start,
+ int end) const {
+ const auto& column_data = assert_cast<const ColumnIPv4&>(column);
+ result.mutable_string_value()->Reserve(end - start);
+ auto* ptype = result.mutable_type();
+ ptype->set_id(PGenericType::IPV4);
+ for (int i = start; i < end; ++i) {
+ IPv4Value ipv4_value(column_data.get_data()[i]);
+ result.add_string_value(ipv4_value.to_string());
Review Comment:
why not use int but `to_string`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
